remove use of empty var QT_LIBRARIES and use VTK_LIBRARIES and ITK_LIBRARIES… #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ITKIOTransformMatlab ITKIOMRC ITKIOTransformInsightLegacy ITKRegistrationCommon | ||
| ITKIOMeta ITKStatistics ITKIOPhilipsREC) | ||
|
|
||
| #ITKCommon ITKTransformFactory |
added 3 commits
April 16, 2020 17:03
…nstead of set_definition, removed unecessary link, use target_include_directories instead of include_directories
| dtkCoreSupport | ||
| dtkLog | ||
| medCore | ||
| medCoreLegacy | ||
| ITKCommon |
There was a problem hiding this comment.
i'm curious, why do you prefer them in the find_package than here?
There was a problem hiding this comment.
I like to put them in the find required section. And I hope that one time I could remove most of them .
| target_compile_definitions(${TARGET_NAME} PUBLIC ${TARGET_NAME_UP}_VERSION="${${TARGET_NAME}_VERSION}") | ||
|
|
||
| ## ############################################################################# | ||
| ## include directorie. |
|
|
||
|
|
||
| ## ############################################################################# | ||
| ## add library | ||
| ## include directorie. |
There was a problem hiding this comment.
*directories (there are some changes like that in the PR)
| find_package(VTK REQUIRED COMPONENTS vtkIOImage) | ||
| include(${VTK_USE_FILE}) | ||
|
|
||
|
|
There was a problem hiding this comment.
you can remove this empty line
| target_compile_definitions(${TARGET_NAME} PUBLIC ${TARGET_NAME_UP}_VERSION="${${TARGET_NAME}_VERSION}") | ||
|
|
||
| ## ############################################################################# | ||
| ## include directorie. |
|
I think there is a problem with the PR @nbaraka you lost all your changes except the last commit :/ |
added 7 commits
April 22, 2020 10:28
…de_directories, done for few vtk , still some remains
…de(VTK_file) but have to add VTK_DEFINITIONS; may have to add some ITK_DEFINITONS
…n project, set add_library kind to be module for plugins : seems to define better what it is planned to compile than shared, but it is not true for plugins that will be linked with other plugins
…arget_compile_definitions in most cmake files, wip for definition
|
It's really cool to improve cmake mechanism and promote "modern cmake" philosophy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To link to specific qt lib : look for qt package with the required lib (for example qtsql).